chore(eslint): add unicorn Switch rules #2881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
added
chore
|
🎊 PR Preview 18e4009 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-doc_preview-pr-2881.surge.sh 🕐 Build time: 0.021s
🤖 By surge-preview |
|
🎊 PR Preview 18e4009 has been successfully built and deployed to https://process-analytics-bpmn-visualization-js-demo_preview-pr-2881.surge.sh 🕐 Build time: 0.016s
🤖 By surge-preview |
- unicorn/no-useless-switch-case - unicorn/prefer-switch - unicorn/switch-case-braces
csouchet
force-pushed
the
2742-add_unicorn_switch_rules
branch
from
f7d739e
to
ee7a75c
Compare
csouchet
removed
the
depends on another PR ⚠️
tbouffard
approved these changes
Sep 25, 2023
| case BpmnStyleIdentifier.IS_INITIATING: // message flow icon | ||
| } | ||
| case BpmnStyleIdentifier.IS_INITIATING: { | ||
| // message flow icon |
There was a problem hiding this comment.
thought: may be clearer with the comment on the top of the case entry. This is what we generally do in the code.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid to have to many changes by enabling plugin:unicorn/recommended, I choose to enable some rule one-by-one.
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-switch-case.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-switch.md
https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/switch-case-braces.md
Part of #2824
Covers #2742